Skip to content

Commit da7679e

Browse files
devversionandrewseguin
authored andcommitted
build: add missing bazel action names (#14910)
In order to have proper action names when running bazel, we should add progress messages for all custom rules. Currently Bazel always uses the first input as action name, but this is *very* confusing since failures lead to the input file, instead of the associated Bazel action. Note that this is not really a progress_message, but it is consistent with native bazel actions (e.g. `StarlarkAction`)
1 parent 0c9d5d4 commit da7679e

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

tools/dgeni/index.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ def _dgeni_api_docs(ctx):
6060
executable = ctx.executable._dgeni_bin,
6161
outputs = expected_outputs,
6262
arguments = [args],
63+
progress_message = "Dgeni (%s)" % (output_dir_path),
6364
)
6465

6566
return DefaultInfo(files = depset(expected_outputs))

tools/highlight-files/index.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ def _highlight_files(ctx):
5959
executable = ctx.executable._highlight_files,
6060
outputs = expected_outputs,
6161
arguments = [args],
62+
progress_message = "HighlightFiles",
6263
)
6364

6465
return DefaultInfo(files = depset(expected_outputs))

tools/markdown-to-html/index.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ def _markdown_to_html(ctx):
4747
executable = ctx.executable._transform_markdown,
4848
outputs = expected_outputs,
4949
arguments = [args],
50+
progress_message = "MarkdownToHtml",
5051
)
5152

5253
return DefaultInfo(files = depset(expected_outputs))

tools/package-docs-content/index.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def _package_docs_content(ctx):
5353
executable = ctx.executable._packager,
5454
outputs = expected_outputs,
5555
arguments = [args],
56+
progress_message = "PackageDocsContent",
5657
)
5758

5859
return DefaultInfo(files = depset(expected_outputs))

tools/sass_bundle.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def _sass_bundle(ctx):
2424
executable = ctx.executable._sass_bundle,
2525
outputs = [ctx.outputs.output_name],
2626
arguments = [args],
27+
progress_message = "SassBundle (%s)" % ctx.attr.output_name,
2728
)
2829

2930
output_depset = depset([ctx.outputs.output_name])

0 commit comments

Comments
 (0)