build: add missing bazel action names #14910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have proper action names when running bazel, we should add progress messages for all custom rules. Currently Bazel always uses the first input as action name, but this is *very* confusing since failures lead to the input file, instead of the associated Bazel action. Note that this is not really a progress_message, but it is consistent with native bazel actions (e.g. `StarlarkAction`)
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jan 25, 2019
In order to have proper action names when running bazel, we should add progress messages for all custom rules. Currently Bazel always uses the first input as action name, but this is *very* confusing since failures lead to the input file, instead of the associated Bazel action. Note that this is not really a progress_message, but it is consistent with native bazel actions (e.g. `StarlarkAction`)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have proper action names when running bazel, we should add progress messages for all custom rules. Currently Bazel always uses the first input as action name, but this is very confusing since failures lead to the input file, instead of the associated Bazel action.
Note that this is not really a progress_message, but it is consistent with native bazel actions (e.g.
StarlarkAction)