Skip to content

Commit e2d9f0e

Browse files
devversionjelbourn
authored andcommitted
build: fix snapshot local browsers cronjob test (#16362)
The `snapshot_tests_local_browsers` job currently seems to fail because in order to run the setup snapshots script, we already need to have the `node_modules` installed. This means that we need to run Yarn twice for the cronjob. Though this shouldn't have any performance implications because we recently updated Yarn to a version that is able to properly cache/restore the `node_modules`.
1 parent 10370ef commit e2d9f0e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.circleci/config.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,11 +367,12 @@ jobs:
367367
- *checkout_code
368368
- *restore_cache
369369
- *yarn_download
370+
- *yarn_install
370371

371372
- run: node ./scripts/circleci/setup-angular-snapshots.js --tag master
372-
# Install yarn dependencies after the package.json has been updated. Note that
373-
# we can't use frozen-lockfile since the setup snapshots script does not update
374-
# the lock file.
373+
# We need to re-run yarn install in order to pull the Angular snapshot builds. Note
374+
# that we can't use the "--frozen-lockfile" option since the setup snapshots script does
375+
# not update the lock file.
375376
- run: yarn install --non-interactive
376377
- run: ./scripts/circleci/run-local-browser-tests.sh
377378

0 commit comments

Comments
 (0)