Skip to content

Commit e85547a

Browse files
rafaelss95tinayuangao
authored andcommitted
refactor: remove duplicate types and correct some TODOs (#10763)
1 parent 1acda9a commit e85547a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/cdk/table/table.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export class CdkTable<T> implements CollectionViewer, OnInit, AfterContentChecke
178178
this._switchDataSource(dataSource);
179179
}
180180
}
181-
private _dataSource: DataSource<T> | Observable<T[]> | T[] | T[];
181+
private _dataSource: DataSource<T> | Observable<T[]> | T[];
182182

183183
// TODO(andrewseguin): Remove max value as the end index
184184
// and instead calculate the view on init and scroll.

src/lib/icon/icon-registry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ export class MatIconRegistry {
544544
return inProgressFetch;
545545
}
546546

547-
// TODO(jelbourn): for some reason, the `finally` operator "loses" the generic type on the
547+
// TODO(jelbourn): for some reason, the `finalize` operator "loses" the generic type on the
548548
// Observable. Figure out why and fix it.
549549
const req = this._httpClient.get(url, {responseType: 'text'}).pipe(
550550
finalize(() => this._inProgressUrlFetches.delete(url)),

src/lib/menu/menu-trigger.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ export const MAT_MENU_SCROLL_STRATEGY =
5252
}
5353
});
5454

55-
// TODO(andrewseguin): Remove the kebab versions in favor of camelCased attribute selectors
56-
5755
/** Default top padding of the menu panel. */
5856
export const MENU_PANEL_TOP_PADDING = 8;
5957

58+
// TODO(andrewseguin): Remove the kebab versions in favor of camelCased attribute selectors
59+
6060
/**
6161
* This directive is intended to be used in conjunction with an mat-menu tag. It is
6262
* responsible for toggling the display of the provided menu instance.

0 commit comments

Comments
 (0)