Skip to content

Commit e8ee641

Browse files
devversionmmalerba
authored andcommitted
build: remove rollup windows postinstall workaround (#17669)
We can remove the rollup windows postinstall workaround since we updated to `@angular/bazel#9.0.0-rc.1` which includes a fix for this issue.
1 parent 1fcea50 commit e8ee641

File tree

3 files changed

+0
-73
lines changed

3 files changed

+0
-73
lines changed

WORKSPACE

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ yarn_install(
4949
"//:tools/bazel/flat_module_factory_resolution.patch",
5050
"//:tools/bazel/manifest_externs_hermeticity.patch",
5151
"//:tools/bazel/postinstall-patches.js",
52-
"//:tools/bazel/rollup_windows_arguments.patch",
5352
"//:tools/npm/check-npm.js",
5453
],
5554
package_json = "//:package.json",

tools/bazel/postinstall-patches.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,6 @@ searchAndReplace(
5858
`,
5959
'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');
6060

61-
// Workaround for https://github.com/angular/angular/issues/32603.
62-
try {
63-
shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
64-
} catch (_) {
65-
// This is getting fixed in ng_rollup_bundle itself but due to the dependency sandwich
66-
// between this repo and the material-unit-test job in the angular repo we need to add
67-
// this try/catch here temporarily.
68-
}
69-
7061
// Workaround for: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ?both. We only want to discard
7162
// the metadata of files in the bazel managed node modules. That way we keep the default
7263
// behavior of ngc-wrapped except for dependencies between sources of the library. This makes

tools/bazel/rollup_windows_arguments.patch

Lines changed: 0 additions & 63 deletions
This file was deleted.

0 commit comments

Comments
 (0)