Skip to content

Commit ef8e163

Browse files
committed
build: move commit message check to be last in pipeline (#29568)
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures. These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR. (cherry picked from commit 64dfcc0)
1 parent 3e83fbb commit ef8e163

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/pr.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,12 @@ jobs:
4242
run: yarn tslint
4343
- name: Check for circular dependencies
4444
run: yarn -s ts-circular-deps:check
45-
- name: Check commit message
46-
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
4745
- name: Check code format
4846
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
47+
# Commit message check is last intentionally, because the caretaker can fix it
48+
# during merge, while other lint failures have to be resolved by the PR author.
49+
- name: Check commit message
50+
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
4951

5052
api_golden_checks:
5153
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)