Skip to content

Commit fee5810

Browse files
authored
refactor(cdk-experimental/column-resize): clean up ReplaySubject usages (#19057)
Replaces some usages of `ReplaySubject` with a plain `Subject` since we don't use ReplaySubject anywhere else in the codebase and in these cases it doesn't provide any benefit. This should lead to less code being imported as a result of the CDK.
1 parent dac84bf commit fee5810

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/cdk-experimental/column-resize/column-resize.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {AfterViewInit, Directive, ElementRef, NgZone, OnDestroy} from '@angular/core';
10-
import {fromEvent, merge, ReplaySubject} from 'rxjs';
10+
import {fromEvent, merge, Subject} from 'rxjs';
1111
import {filter, map, mapTo, pairwise, startWith, take, takeUntil} from 'rxjs/operators';
1212

1313
import {_closest, _matches} from '@angular/cdk-experimental/popover-edit';
@@ -27,7 +27,7 @@ let nextId = 0;
2727
*/
2828
@Directive()
2929
export abstract class ColumnResize implements AfterViewInit, OnDestroy {
30-
protected readonly destroyed = new ReplaySubject<void>();
30+
protected readonly destroyed = new Subject<void>();
3131

3232
/* Publicly accessible interface for triggering and being notified of resizes. */
3333
abstract readonly columnResizeNotifier: ColumnResizeNotifier;

src/cdk-experimental/column-resize/overlay-handle.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {coerceCssPixelValue} from '@angular/cdk/coercion';
1111
import {Directionality} from '@angular/cdk/bidi';
1212
import {ESCAPE} from '@angular/cdk/keycodes';
1313
import {CdkColumnDef} from '@angular/cdk/table';
14-
import {fromEvent, ReplaySubject} from 'rxjs';
14+
import {fromEvent, Subject} from 'rxjs';
1515
import {
1616
distinctUntilChanged,
1717
filter,
@@ -37,7 +37,7 @@ import {ResizeRef} from './resize-ref';
3737
*/
3838
@Directive()
3939
export abstract class ResizeOverlayHandle implements AfterViewInit, OnDestroy {
40-
protected readonly destroyed = new ReplaySubject<void>();
40+
protected readonly destroyed = new Subject<void>();
4141

4242
protected abstract readonly columnDef: CdkColumnDef;
4343
protected abstract readonly document: Document;

src/cdk-experimental/column-resize/resizable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {Directionality} from '@angular/cdk/bidi';
2121
import {ComponentPortal, PortalInjector} from '@angular/cdk/portal';
2222
import {Overlay, OverlayRef} from '@angular/cdk/overlay';
2323
import {CdkColumnDef} from '@angular/cdk/table';
24-
import {merge, ReplaySubject} from 'rxjs';
24+
import {merge, Subject} from 'rxjs';
2525
import {filter, takeUntil} from 'rxjs/operators';
2626

2727
import {_closest} from '@angular/cdk-experimental/popover-edit';
@@ -48,7 +48,7 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
4848

4949
protected inlineHandle?: HTMLElement;
5050
protected overlayRef?: OverlayRef;
51-
protected readonly destroyed = new ReplaySubject<void>();
51+
protected readonly destroyed = new Subject<void>();
5252

5353
protected abstract readonly columnDef: CdkColumnDef;
5454
protected abstract readonly columnResize: ColumnResize;

0 commit comments

Comments
 (0)