refactor(cdk-experimental/column-resize): clean up ReplaySubject usages #19057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces some usages of `ReplaySubject` with a plain `Subject` since we don't use ReplaySubject anywhere else in the codebase and in these cases it doesn't provide any benefit. This should lead to less code being imported as a result of the CDK.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 13, 2020
| @@ -27,7 +27,7 @@ let nextId = 0; | |||
| */ | |||
| @Directive() | |||
| export abstract class ColumnResize implements AfterViewInit, OnDestroy { | |||
| protected readonly destroyed = new ReplaySubject<void>(); | |||
| protected readonly destroyed = new Subject<void>(); | |||
There was a problem hiding this comment.
Is there any chance of something being destroyed before we subscribe to it? In that case the ReplaySubject would actually be important
There was a problem hiding this comment.
There are only internal subscriptions to this subject so it shouldn't be possible.
andrewseguin
approved these changes
Jun 15, 2020
andrewseguin
added
lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jun 17, 2020
…es (#19057) Replaces some usages of `ReplaySubject` with a plain `Subject` since we don't use ReplaySubject anywhere else in the codebase and in these cases it doesn't provide any benefit. This should lead to less code being imported as a result of the CDK.
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Jun 18, 2020
…es (angular#19057) Replaces some usages of `ReplaySubject` with a plain `Subject` since we don't use ReplaySubject anywhere else in the codebase and in these cases it doesn't provide any benefit. This should lead to less code being imported as a result of the CDK.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces some usages of
ReplaySubjectwith a plainSubjectsince we don't use ReplaySubject anywhere else in the codebase and in these cases it doesn't provide any benefit. This should lead to less code being imported as a result of the CDK.