Skip to content

feat(menu): allow for backdrop to be disabled #10070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

crisbeto
Copy link
Member

Adds the hasBackdrop input on the MatMenu directive, allowing consumers to remove the backdrop.

Fixes #9938.

@crisbeto crisbeto requested a review from kara as a code owner February 21, 2018 18:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 21, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: minor This PR is targeted for the next minor release pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 21, 2018
@crisbeto crisbeto force-pushed the 9938/menu-disable-backdrop branch from 4e2e87f to 65e97dc Compare February 21, 2018 19:53
@jelbourn
Copy link
Member

@crisbeto needs rebase

Adds the `hasBackdrop` input on the `MatMenu` directive, allowing consumers to remove the backdrop.

Fixes angular#9938.
@crisbeto crisbeto force-pushed the 9938/menu-disable-backdrop branch from 65e97dc to a77d6fb Compare February 26, 2018 17:12
@crisbeto
Copy link
Member Author

Rebased.

@tinayuangao tinayuangao merged commit e42f0bc into angular:master Feb 28, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mat-Menu] Feature Request : add ability to remove backdrop
4 participants