Skip to content

refactor(radio): remove 6.0.0 deletion targets #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 1, 2018

Removes the deletion targets for 6.0.0 in the material/radio entry point.

BREAKING CHANGES:

  • align input in MatRadioGroup which was deprecated in 5.0.0 has been removed. Use labelPosition instead.
  • align input in MatRadioButton which was deprecated in 5.0.0 has been removed. Use labelPosition instead.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member Author

crisbeto commented Mar 1, 2018

Caretaker note: we need to remove google usages of the old API. This might require a cleanup before syncing this PR.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 1, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Removes the deletion targets for 6.0.0 in the `material/radio` entry point.

BREAKING CHANGES:
* `align` input in `MatRadioGroup` which was deprecated in 5.0.0 has been removed. Use `labelPosition` instead.
* `align` input in `MatRadioButton` which was deprecated in 5.0.0 has been removed. Use `labelPosition` instead.
@crisbeto crisbeto force-pushed the radio-6.0.0-deletion-targets branch from 6097f1b to b732756 Compare March 2, 2018 21:06
@jelbourn jelbourn merged commit 3f8523c into angular:master Mar 6, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants