fix(drawer): show backdrop in "side" mode if hasBackdrop is explicitly set to true #10251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y set to true Currently we only use `hasBackdrop` to hide the backdrop, however setting it to `true` explicitly also expresses an intent that the consumer might want the backdrop to always be shown. These changes make it so backdrop will also be shown for `side` drawers if `hasBackdrop` is set to `true`.
googlebot
added
the
cla: yes
mmalerba
reviewed
Mar 5, 2018
| } | ||
|
|
||
| private _isDrawerOpen(drawer: MatDrawer | null): boolean { | ||
| private _isDrawerOpen(drawer: MatDrawer | null): drawer is MatDrawer { |
There was a problem hiding this comment.
is this a mistake or some crazy typescript thing I don't know about?
There was a problem hiding this comment.
It's a crazy TS thing. It lets TS know that from now on the drawer is going to be a MatDrawer rather than a MatDrawer | null.
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only use
hasBackdropto hide the backdrop, however setting it totrueexplicitly also expresses an intent that the consumer might want the backdrop to always be shown. These changes make it so backdrop will also be shown forsidedrawers ifhasBackdropis set totrue.