feat(snack-bar): add the ability to open from a TemplateRef #10268
Conversation
Allows consumers to open a snack bar through a custom `TemplateRef`, in addition to a component type. Fixes angular#6136.
googlebot
added
the
cla: yes
| * @param template Template to be instantiated. | ||
| * @param config Extra configuration for the snack bar. | ||
| */ | ||
| openFromTemplate(template: TemplateRef<any>, config?: MatSnackBarConfig): |
There was a problem hiding this comment.
Point for discussion: currently the font size and color styling are attached to the SimpleSnackBar, which means that consumers that open through openFromComponent and openFromTemplate won't get the styling. Should we switch to attaching them on the MatSnackBarContainer instead?
There was a problem hiding this comment.
We could do it for templates since its new, but changing it now for components could be seen as a breaking change.
There was a problem hiding this comment.
I think that we should not do it at all, especially if we plan on having it be different between templates and components.
It was done this way as the SimpleSnackBar is the snack bar that matches the spec and we give users full control with opening a custom snackbar.
| * @param template Template to be instantiated. | ||
| * @param config Extra configuration for the snack bar. | ||
| */ | ||
| openFromTemplate(template: TemplateRef<any>, config?: MatSnackBarConfig): |
There was a problem hiding this comment.
We could do it for templates since its new, but changing it now for components could be seen as a breaking change.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows consumers to open a snack bar through a custom
TemplateRef, in addition to a component type.Fixes #6136.