Skip to content

fix(table): move padding from rows to cells #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

andrewseguin
Copy link
Contributor

Moves the material table's row padding to the first and last cells. This matches native tables which do not support row padding.

BREAKING CHANGES:

  • The mat-table has moved its row padding to be on the first and last cells. This matches native tables which do not support row padding.

@andrewseguin andrewseguin added pr: lgtm target: major This PR is targeted for the next major release labels Mar 20, 2018
@andrewseguin andrewseguin requested a review from mmalerba March 20, 2018 16:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2018
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2018
@andrewseguin andrewseguin merged commit e0321db into angular:master Mar 20, 2018
@vartan
Copy link

vartan commented Mar 29, 2018

setting display:flex broke text-align in my existing UIs, what is the justification of setting display:flex on a cell?

@andrewseguin
Copy link
Contributor Author

@vartan This change is required so that cells can set a min-height, which will be necessary when we want to add the sticky-columns feature.

To resolve your issue, switch text-align: right to justify-content: flex-end. Here's a quick example of this: https://stackblitz.com/edit/js-hpqpt9?file=index.html

@andrewseguin andrewseguin deleted the table-padding-on-cells branch April 17, 2018 17:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants