-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build(bazel): add rule for cdk npm package #10509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,22 @@ | ||
# List of all @angular/material components / subpackages. | ||
CDK_PACKAGES = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you want to try a bit harder to glob these, so adding a new subdirectory will automatically do the right thing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestions? |
||
"coercion", | ||
"keycodes", | ||
"scrolling", | ||
"accordion", | ||
"observers", | ||
"a11y", | ||
"overlay", | ||
"platform", | ||
"bidi", | ||
"table", | ||
"tree", | ||
"portal", | ||
"layout", | ||
"stepper", | ||
"collections", | ||
] | ||
|
||
MATERIAL_PACKAGES = [ | ||
"autocomplete", | ||
"badge", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
package(default_visibility=["//visibility:public"]) | ||
load("@build_bazel_rules_typescript//:defs.bzl", "ts_library") | ||
load("@angular//:index.bzl", "ng_module") | ||
|
||
# Note: this will need to ng_module if any Angular-specific stuff is added to coercion. | ||
ts_library( | ||
|
||
ng_module( | ||
name = "keycodes", | ||
srcs = glob(["**/*.ts"], exclude=["**/*.spec.ts"]), | ||
module_name = "@angular/cdk/keycodes", | ||
deps = [], | ||
tsconfig = ":tsconfig-build.json", | ||
deps = ["@rxjs"], | ||
tsconfig = "//src/cdk:tsconfig-build.json", | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
load("//:packages.bzl", "CDK_PACKAGES") | ||
|
||
# Base rollup globals for dependencies and the root entry-point. | ||
CDK_ROLLUP_GLOBALS = { | ||
'tslib': 'tslib', | ||
'@angular/cdk': 'ng.cdk', | ||
} | ||
|
||
# Rollup globals for subpackages in the form of, e.g., {"@angular/cdk/table": "ng.cdk.table"} | ||
CDK_ROLLUP_GLOBALS.update({ | ||
"@angular/cdk/%s" % p: "ng.cdk.%s" % p for p in CDK_PACKAGES | ||
}) |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,7 @@ export class StepperSelectionEvent { | |
moduleId: module.id, | ||
selector: 'cdk-step', | ||
exportAs: 'cdkStep', | ||
templateUrl: 'step.html', | ||
template: '<ng-template><ng-content></ng-content></ng-template>', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this wasn't necessary, right? the resource inlining has landed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wasn't necessary, just cleaned it up incidentally since the template was trivial. |
||
encapsulation: ViewEncapsulation.None, | ||
changeDetection: ChangeDetectionStrategy.OnPush, | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you want to update all the
@angular/*
in lock-step?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't update the rest due to rxjs 6.0, which we don't have working yet