refactor(live-announcer): run outside NgZone #10631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Mar 30, 2018
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto Please rebase. Thanks |
|
Rebased. |
crisbeto
force-pushed
the
live-announcer-ng-zone
branch
from
8d3d271 to
5b75144
Compare
crisbeto
force-pushed
the
live-announcer-ng-zone
branch
from
5b75144 to
51400b1
Compare
andrewseguin
added
the
presubmit failures
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
live-announcer-ng-zone
branch
from
51400b1 to
a02075f
Compare
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Switches to running the timeout from the `LiveAnnouncer` outside the `NgZone`, because it does all of its DOM manipulation directly on the element and it doesn't have to trigger Angular's change detection.
crisbeto
force-pushed
the
live-announcer-ng-zone
branch
from
a02075f to
bba3f07
Compare
vivian-hu-zz
removed
the
presubmit failures
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Switches to running the timeout from the `LiveAnnouncer` outside the `NgZone`, because it does all of its DOM manipulation directly on the element and it doesn't have to trigger Angular's change detection.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to running the timeout from the
LiveAnnounceroutside theNgZone, because it does all of its DOM manipulation directly on the element and it doesn't have to trigger Angular's change detection.