feat(coercion): add utility for coercing CSS values #10654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 2, 2018
src/cdk/coercion/css-property.ts
Outdated
| */ | ||
|
|
||
| /** Coerces a value to a string that can be assigned as a CSS property. */ | ||
| export function coerceCssProperty(value: any): string { |
There was a problem hiding this comment.
I think we either need to make it work with different units and call the function coerceCssUnitValue or it can stay just pixels and be coerceCssPixelValue
There was a problem hiding this comment.
I'd rather keep it to pixels so we don't have to keep up with the different units. Changed the naming and we can reconsider if somebody requests it.
Also TIL that CSS has frequency units: https://developer.mozilla.org/en-US/docs/Web/CSS/frequency
Moves some duplicated logic for coercing CSS values under `cdk/coercion` and replaces the usages.
crisbeto
force-pushed
the
coercion-css-unit
branch
from
d1834df to
594327f
Compare
jelbourn
added
pr: lgtm
action: merge
Longfld
pushed a commit
to Longfld/material2
that referenced
this pull request
Apr 6, 2018
Moves some duplicated logic for coercing CSS values under `cdk/coercion` and replaces the usages.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some duplicated logic for coercing CSS values under
cdk/coercionand replaces the usages.