fix(datepicker): close datepicker popup on alt + up arrow #10662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: needs review
Accessibility
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 2, 2018
src/lib/datepicker/datepicker.ts
Outdated
| @@ -138,6 +139,13 @@ export class MatDatepickerContent<D> extends _MatDatepickerContentMixinBase | |||
| }); | |||
| } | |||
|
|
|||
| _handleKeydown(event: KeyboardEvent) { | |||
| // Closing on alt + up is only valid when there's an input associated with the datepicker. | |||
| if (this.datepicker._datepickerInput && event.altKey && event.keyCode === UP_ARROW) { | |||
There was a problem hiding this comment.
The Esc appears to be handled on the overlayRef (line 475), should this be the same?
There was a problem hiding this comment.
Totally forgot that we had that. Changed.
Similarly to other controls that are based around an input and a popup, the datepicker should open on alt + down arrow and close on alt + up arrow. The opening logic was already being handled and this PR adds the logic for closing.
crisbeto
force-pushed
the
datepicker-alt-up-arrow
branch
from
2375a3e to
fdfa278
Compare
mmalerba
approved these changes
Apr 2, 2018
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to other controls that are based around an input and a popup, the datepicker should open on alt + down arrow and close on alt + up arrow. The opening logic was already being handled and this PR adds the logic for closing.