Skip to content

fix: remove duplicate imports #10692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2018
Merged

fix: remove duplicate imports #10692

merged 1 commit into from
Apr 5, 2018

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Apr 4, 2018 •
edited
Loading

This removes all duplicate imports. Some of them were added in #10496.

I also added a tslint rule to keep it consistent.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2018
@rafaelss95 rafaelss95 requested a review from amcdnl as a code owner April 4, 2018 02:38
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 4, 2018
crisbeto
crisbeto approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit b85ee8c into angular:master Apr 5, 2018
@rafaelss95 rafaelss95 deleted the duplicate-imports branch April 5, 2018 16:20
Longfld pushed a commit to Longfld/material2 that referenced this pull request Apr 6, 2018
@rafaelss95 @Longfld
chore: remove duplicate imports (angular#10692)
59e0db8
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

@kara kara Awaiting requested review from kara

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rafaelss95 @crisbeto @josephperrott @mmalerba @jelbourn @googlebot