-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(paginator): expose previousPageIndex inside PageEvent #10759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paginator): expose previousPageIndex inside PageEvent #10759
Conversation
bd025ea
to
45cd2a1
Compare
I'm not sure it would be related to that, but the trigger which emits Or, just an idea, following core's
|
@lacolaco I was trying to avoid a breaking API change. We can reconsider changing up the interface in the next major version. |
@crisbeto You're right. I'm wondering ain't there a way to solve it without BCs. Thanks. |
I'm finding that many internal Google tests are failing because sometimes users create their own Would it make more sense to mark this field as optional to avoid a breaking change, as well as eliminate the need for such use cases to define a previous page index? |
* Exposes the previous page index inside the object that is emitted by the `page` event. * Reworks the `page` event tests to use a spy rather than saving the last result to the test component. Fixes angular#10758.
45cd2a1
to
bec262f
Compare
I've made it optional with a target to make it required in 7.0 @andrewseguin. Otherwise, I'm not sure whether we can eliminate the need for this property completely, e.g. I can see it coming in handy if we add the ability to jump to a page. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
page
event.page
event tests to use a spy rather than saving the last result to the test component.Fixes #10758.