Skip to content

build: fix sass compilation error #10806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

crisbeto
Copy link
Member

Fixes the following SASS error due to a top-level ampersand selector:

Error in plugin 'sass'
Message:
    src\lib\core\_core.scss
Error: Base-level rules cannot contain the parent-selector-referencing character '&'.
        on line 43 of src/lib/core/_core.scss, in mixin `mat-core-theme`
        from line 39 of src/lib/core/theming/_all-theme.scss, in mixin `angular-material-theme`
        from line 14 of src/lib/core/theming/prebuilt/deeppurple-amber.scss
>>   &.mat-app-background {

   --^

@crisbeto crisbeto requested a review from jelbourn as a code owner April 11, 2018 18:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 11, 2018
Fixes the following SASS error due to a top-level ampersand selector:

```
Error in plugin 'sass'
Message:
    src\lib\core\_core.scss
Error: Base-level rules cannot contain the parent-selector-referencing character '&'.
        on line 43 of src/lib/core/_core.scss, in mixin `mat-core-theme`
        from line 39 of src/lib/core/theming/_all-theme.scss, in mixin `angular-material-theme`
        from line 14 of src/lib/core/theming/prebuilt/deeppurple-amber.scss
>>   &.mat-app-background {

   --^
```
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 11, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not realize that SASS didn't automatically handle this.

@tinayuangao tinayuangao merged commit 23cedc1 into angular:master Apr 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants