Skip to content

chore: set up angular-robot for repo #10840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

chore: set up angular-robot for repo #10840

merged 1 commit into from
Apr 16, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 13, 2018
jelbourn
jelbourn approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 13, 2018
@josephperrott josephperrott added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Apr 13, 2018
@josephperrott
Copy link
Member Author

Blocked by submission and release of version including: angular/github-robot#1

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Apr 16, 2018
@mmalerba
Copy link
Contributor

@josephperrott re-apply merge ready when unblocked

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Apr 16, 2018
@josephperrott
Copy link
Member Author

@mmalerba Confirmed with Olivier, we are good to merge this.

@mmalerba mmalerba merged commit ddb443a into angular:master Apr 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @mmalerba @jelbourn @googlebot