fix(chips): unable to bind to chip input placeholder #10855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Apr 14, 2018
| @@ -38,6 +38,7 @@ let nextUniqueId = 0; | |||
| '(focus)': '_focus()', | |||
| '(input)': '_onInput()', | |||
| '[id]': 'id', | |||
| '[attr.placeholder]': 'placeholder || null', | |||
There was a problem hiding this comment.
@tinayuangao should we deprecate the placeholder input for 7.0? It doesn't do anything, apart from proxying the value to the placeholder attribute. Consumers can achieve the same by binding to attr.placeholder.
tinayuangao
approved these changes
Apr 23, 2018
| @@ -38,6 +38,7 @@ let nextUniqueId = 0; | |||
| '(focus)': '_focus()', | |||
| '(input)': '_onInput()', | |||
| '[id]': 'id', | |||
| '[attr.placeholder]': 'placeholder || null', | |||
tinayuangao
added
pr: lgtm
action: merge
Fixes the value that is bound to the `placeholder` input not being assigned to the `placeholder` attribute. Fixes angular#10848.
crisbeto
force-pushed
the
10848/chip-input-placeholder
branch
from
563c2da to
da963d3
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the value that is bound to the
placeholderinput not being assigned to theplaceholderattribute.Fixes #10848.