fix(icon): log full error message when icon set fails to load #10915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 25, 2018
src/lib/icon/icon-registry.ts
Outdated
| console.log(`Loading icon set URL: ${url} failed: ${err}`); | ||
| // Swallow errors fetching individual URLs so the | ||
| // combined Observable won't necessarily fail. | ||
| console.log(`Loading icon set URL: ${url} failed: ${err.message}`); |
There was a problem hiding this comment.
Should this be console.error while we're changing this anyway?
Currently when an icon request fails, we log something along the lines of `"Loading icon set URL: {{url}} failed: [object Object]"`. These changes switch to logging out the error message rather than the entire object.
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
May 4, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an icon request fails, we log something along the lines of
"Loading icon set URL: {{url}} failed: [object Object]". These changes switch to logging out the error message rather than the entire object.