Skip to content

fix(button-toggle): initialize falsy value for multiple button group #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rhutchison
Copy link

When using form control, an initialized falsy value will not be selected.

@rhutchison rhutchison requested a review from tinayuangao as a code owner April 19, 2018 19:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 19, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhutchison rhutchison force-pushed the button-toggle-multiple-with-falsy-value branch 2 times, most recently from 7d02fd9 to aec33f8 Compare May 9, 2018 01:09
@rhutchison rhutchison force-pushed the button-toggle-multiple-with-falsy-value branch from aec33f8 to c61fff9 Compare May 9, 2018 01:18
@rhutchison
Copy link
Author

@tinayuangao I rebased to resolve conflicts... can proper labels be added?

@ngbot
Copy link

ngbot bot commented May 22, 2018

Hi @rhutchison! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented May 22, 2018

Hi @rhutchison! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@rhutchison
Copy link
Author

Resolved by #11292

@rhutchison rhutchison closed this May 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants