-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(form-field): inconsistent border width across outline gap in Chrome #10956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA is signed! |
CLAs look good, thanks! |
4b2bbd7
to
0772492
Compare
Sorry for all the noise on CI, clearly I need some rest. I think this should be ready to be looked at! |
Thanks for the PR. I'll need to bring up some demos and test across different browsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great on the browsers I tested!
opacity: 1; | ||
transition: opacity 300ms $swift-ease-out-timing-function; | ||
} | ||
// hack for Chrome's treatment of border width on non-integer displays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you read about this somewhere, or just figured it out through experimentation? If you read about it, it would be nice to include a link for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this was just through experimentation! Unfortunately I couldn't find any reported issue related to this. I don't imagine this scenario comes up too often.
Closes angular#10710. Chrome render borders that have non-integer widths differently when a border-radius is set. This adds an imperceptibly small border radius to the outline gap so that it renders the same as the outside borders.
0772492
to
c6e5f5c
Compare
I just tweaked my comment to be a bit more accurate and updated the issue reference to be a URL rather than just the issue number. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #10710 (You can see screenshots there).
Chrome render borders that have non-integer widths differently when a border-radius is set. This adds an imperceptibly small border radius to the outline gap so that it renders the same as the outside borders.