Skip to content

feat(autocomplete): allow autocomplete panel to be disabled #11142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2018

Allows for the autocomplete trigger to be disabled without disabling the input or making it readonly. When disabled, all autocomplete-related accessibility will be removed and the user won't be able to open the panel. This is useful for cases where the input might be optionally become an autocomplete, based on certain conditions, which usually isn't possible because directives can't be applied conditionally.

Fixes #11096.

Allows for the autocomplete trigger to be disabled without disabling the input or making it readonly. When disabled, all autocomplete-related accessibility will be removed and the user won't be able to open the panel. This is useful for cases where the input might be optionally become an autocomplete, based on certain conditions, which usually isn't possible because directives can't be applied conditionally.

Fixes angular#11096.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatAutocomplete directive with undefined value should be ignored and not throw exception
5 participants