Skip to content

fix(scrolling): adds right to fix pushed content #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2018
Merged

fix(scrolling): adds right to fix pushed content #11192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b43d952
fix(scrolling): adds right to fix pushed content
amcdnl May 6, 2018
9685000
chore: address feedback
amcdnl May 7, 2018
427e682
chore: address pr feedback
amcdnl May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cdk-experimental/scrolling/virtual-scroll-viewport.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ cdk-virtual-scroll-viewport {
will-change: contents, transform;
}

.virtual-scroll-orientation-horizontal {
bottom: 0;
}

.virtual-scroll-orientation-vertical {
right: 0;
}

// Spacer element that whose width or height will be adjusted to match the size of the entire data
// set if it were rendered all at once. This ensures that the scrollable content region is the
// correct size.
Expand Down
2 changes: 2 additions & 0 deletions src/cdk-experimental/scrolling/virtual-scroll-viewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ function rangesEqual(r1: ListRange, r2: ListRange): boolean {
styleUrls: ['virtual-scroll-viewport.css'],
host: {
'class': 'cdk-virtual-scroll-viewport',
'[class.virtual-scroll-orientation-horizontal]': 'orientation === "horizontal"',
'[class.virtual-scroll-orientation-vertical]': 'orientation === "vertical"',
},
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down