Skip to content

virtual-scroll: add update method #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

virtual-scroll: add update method #11210

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
23d2084
feat(scroll): add update method
amcdnl May 7, 2018
d6c3c52
chore: address feedback
amcdnl May 7, 2018
94ddfb7
chore: address feedback
amcdnl May 7, 2018
1382b58
chore: nit feedback
amcdnl May 13, 2018
6402889
chore: tests
amcdnl May 13, 2018
2c1625b
Merge branch 'virtual-scroll' into force-resize
amcdnl May 13, 2018
04bdfc3
chore: address pr feedback
amcdnl May 16, 2018
bb92f06
chore: fix feedback
amcdnl May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/cdk-experimental/scrolling/virtual-scroll-viewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,15 @@ export class CdkVirtualScrollViewport implements DoCheck, OnInit, OnDestroy {
this._detachedSubject.complete();
}

/** Update the viewport dimensions and re-render. */
updateViewport() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: updateViewportSize to be a little more specific about the purpose

const viewportEl = this.elementRef.nativeElement;
this._viewportSize = this.orientation === 'horizontal' ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this also appears in the Promise above, can we extract it into a separate _measureViewportSize method

viewportEl.clientWidth : viewportEl.clientHeight;

this._scrollStrategy.onDataLengthChanged();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird to be calling onDataLengthChanged here since the data length did not change. Can you just leave a TODO so I remember to clean this up later. I'm going to add logic for handling content resize, this can probably call whatever method I create for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

/** Attaches a `CdkVirtualForOf` to this viewport. */
attach(forOf: CdkVirtualForOf<any>) {
if (this._forOf) {
Expand Down