fix(icon): remove duplicate icon registry provider #11214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
reviewed
May 8, 2018
| @@ -16,6 +16,5 @@ import {ICON_REGISTRY_PROVIDER} from './icon-registry'; | |||
| imports: [MatCommonModule], | |||
| exports: [MatIcon, MatCommonModule], | |||
| declarations: [MatIcon], | |||
| providers: [ICON_REGISTRY_PROVIDER], | |||
There was a problem hiding this comment.
Where's the other provider?
There was a problem hiding this comment.
My guess is that it's a duplicate because the thing it provides (MatIconRegistry) is now a tree-shakeable provider
There was a problem hiding this comment.
jelbourn
force-pushed
the
icon-provider-dupe
branch
from
93be294 to
c3456a5
Compare
jelbourn
added a commit
to jelbourn/components
that referenced
this pull request
May 14, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.