build: fix tests crashing IE test runs #11287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another step towards re-enabling test runs against IE11. Fixes the tests that outright crashed the test run due to an "Unspecified error". The error was being thrown, because we were attempting to get the client rect of an element that wasn't in the DOM. These changes also fix a handful of tests that were leaking DOM elements. We should now be able to do an uninterrupted test run on IE, although there are still a handful of failing tests that might require code changes.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards re-enabling test runs against IE11. Fixes the tests that outright crashed the test run due to an "Unspecified error". The error was being thrown, because we were attempting to get the client rect of an element that wasn't in the DOM. These changes also fix a handful of tests that were leaking DOM elements. We should now be able to do an uninterrupted test run on IE, although there are still a handful of failing tests that might require code changes.