fix(tabs): Add role to mat-tab-nav-bar and mat-tab-link #11410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
reviewed
May 21, 2018
| const fixture = TestBed.createComponent(TabLink); | ||
| fixture.detectChanges(); | ||
|
|
||
| const tabList = fixture.debugElement.query(By.css('[role=tablist]')); |
There was a problem hiding this comment.
You query by role=tablist which means the role must be tablist. Is it better to query by class=mat-tab-links and check the role?
stevenyxu
force-pushed
the
tab-nav-bar-role
branch
from
ad06f79 to
f3f1676
Compare
|
LGTM for a11y |
This is already correctly set on the main tab component: https://material.angular.io/components/tabs/overview mat-tab-group has role="tablist" https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-header.html#L11 mat-tab has role="tab" https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-group.html#L6 But the standalone version mat-tab-nav-bar and mat-tab-link do not have role set. This is a potential breaking change insofar as someone was already setting role explicitly (test added for this case to verify it doesn't break), but the impact is low and should be rare: I have found no examples on github and only two examples in google3 of role being set, and at worse it sets role="tablist" on mat-tab-nav-bar, which would result in a duplicate role="tablist" nested one layer below, but which is not that harmful and is easy to fix. Existing code that directly sets role on mat-tab-link will have that role overridden, but I don't know that this is currently happening.
stevenyxu
force-pushed
the
tab-nav-bar-role
branch
from
f3f1676 to
0064dec
Compare
|
Thank you! Rebased and ready for further review. |
andrewseguin
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
May 30, 2018
|
@stevenyxu FYI this is being reverted in #11657. The nav-tabs follows the pattern of |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already correctly set on the main tab component:
https://material.angular.io/components/tabs/overview
mat-tab-group has role="tablist"
https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-header.html#L11
mat-tab has role="tab"
https://github.com/angular/material2/blob/abc3d38c57146443c848d5ba26fd2fab8ca185d6/src/lib/tabs/tab-group.html#L6
But the standalone version mat-tab-nav-bar and mat-tab-link do not have role set.
This is a potential breaking change insofar as someone was already setting role explicitly (test
added for this case to verify it doesn't break), but the impact is low and should be rare: I have
found no examples on github and only two examples in google3 of role being set, and at worse it sets
role="tablist" on mat-tab-nav-bar, which would result in a duplicate role="tablist" nested one layer
below, but which is not that harmful and is easy to fix. Existing code that directly sets role on
mat-tab-link will have that role overridden, but I don't know that this is currently happening.