fix(slider): disable animations when using NoopAnimationsModule #11422
Conversation
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
src/lib/slider/slider.ts
Outdated
| @@ -431,7 +434,8 @@ export class MatSlider extends _MatSliderMixinBase | |||
| private _focusMonitor: FocusMonitor, | |||
| private _changeDetectorRef: ChangeDetectorRef, | |||
| @Optional() private _dir: Directionality, | |||
| @Attribute('tabindex') tabIndex: string) { | |||
| @Attribute('tabindex') tabIndex: string, | |||
| @Optional() @Inject(ANIMATION_MODULE_TYPE) public _animationMode?: string) { | |||
There was a problem hiding this comment.
leave comment to remove ? at next major
Fixes the slider animations not being disabled when the consumer uses the `NoopAnimationsModule`. Relates to angular#10590.
crisbeto
force-pushed
the
11408/slider-noop-animatons
branch
from
55c586f to
31bcbc2
Compare
crisbeto
added
action: merge
Fixes the slider animations not being disabled when the consumer uses the `NoopAnimationsModule`. Relates to #10590.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the slider animations not being disabled when the consumer uses the
NoopAnimationsModule.Relates to #10590.