fix(form-field): fix wrong underline color in error state #11447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong color of the form-field undeline when using color=accent and the field is in an invalid state and focused. Previously when a form-field using the accent color had an error it would show on focus the accent color instead of the warn color. All other visual elements of the form-field (borders, labels etc) use the warn color in this state. Closes #11436
googlebot
added
the
cla: yes
crisbeto
reviewed
May 27, 2018
| @@ -86,6 +86,10 @@ | |||
|
|
|||
| .mat-form-field-ripple { | |||
| background-color: $underline-color-warn; | |||
|
|
|||
| &.mat-accent { | |||
There was a problem hiding this comment.
Can you combine this selector with the one from above? e.g.
.mat-form-field-ripple,
.mat-form-field-ripple.mat-accent {
background-color: $underline-color-warn;
}
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
May 30, 2018
andrewseguin
pushed a commit
that referenced
this pull request
Jun 8, 2018
* fix(form-field): fix wrong underline color in error state Fix wrong color of the form-field undeline when using color=accent and the field is in an invalid state and focused. Previously when a form-field using the accent color had an error it would show on focus the accent color instead of the warn color. All other visual elements of the form-field (borders, labels etc) use the warn color in this state. Closes #11436 * refactor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong color of the form-field undeline when using color=accent and the field is in an invalid state and focused.
Previously when a form-field using the accent color had an error it would show on focus the accent color instead of the warn color.
All other visual elements of the form-field (borders, labels etc) use the warn color in this state.
Closes #11436