-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(nav-schematics): update isHandset$ type and fix template expression #11448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nav-schematics): update isHandset$ type and fix template expression #11448
Conversation
… template expression Fixes angular#11445, fixes angular#11441
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Excellent - when do we expect this fix to be available for use? I see it has been merged with master but the version that comes down when ng g @angular/material:material-nav is called still has the issues. |
Great thanks a lot man saved my day! |
The fix works, however the generated spec still fails, with the following error: 2 timer(s) still in the queue. (Dunno - should I open a new issue or is it related to this one?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #11445
Fixes #11441