-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(stepper): Create MAT_STEPPER_GLOBAL_OPTIONS InjectionToken #11457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8712df9
feat(stepper): add state input to step
arodr967 48b3f1f
feat(stepper): add state input to step
arodr967 4adb591
feat(stepper): add showError Input, update _getIndicatorType logic, a…
arodr967 beda45f
feat(stepper): create stepper global options and update logic in _get…
arodr967 1cc2f91
test(stepper): revert unit and e2e tests
arodr967 4d671f6
refactor(stepper-demo): revert to previous state
arodr967 820dc54
refactor(stepper): fix lint issues
arodr967 b3d5134
refactor(stepper): parameter formatting and fix typo
arodr967 fdbf799
test(stepper): refactor stepper unit tests and add new tests
arodr967 ebf59a4
docs(stepper): add info about MAT_STEPPER_GLOBAL_OPTIONS
arodr967 f1e3b02
refactor(stepper): remove extra string from some types using StepState
arodr967 9f48437
refactor(stepper): rename useGuidelines to displayDefaultIndicatorTyp…
arodr967 726ce77
docs(stepper): add embedded examples
arodr967 ed4e121
fix(stepper): make stepperOptions an optional parameter
arodr967 4e952fe
refactor(stepper): rename mat-step-icon-not-selected class to mat-ste…
arodr967 ea4ded3
feat(stepper): only show step error after it has been interacted with
arodr967 b3d11ef
fix(stepper): add back both not-touched and not-selected css classes
arodr967 e5bceb3
fix(stepper): add state specific css classes
arodr967 f2ccadc
refactor(stepper): use not selector instead of extra css class
arodr967 8cd1910
fix(stepper): use css specificity in order to remove the use of impor…
arodr967 10fc780
remove -not-selected class
mmalerba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this just the same as
string
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but like this it is clear to the developer that the default states that we are using are
'number' | 'edit' | 'done' | 'error'
and that the developer also has the option to define their ownstate
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reference the enum here instead of repeating all the literals
STEP_STATE | string