-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(button): add mat-flat-button #11587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and remove incorrect theming paragraph. By default, all buttons use the primary color.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
Von: googlebot <[email protected]>
Gesendet: Donnerstag, 31. Mai 2018 00:17
An: angular/material2 <[email protected]>
Cc: F. Schmidt <[email protected]>; Author <[email protected]>
Betreff: Re: [angular/material2] docs(button): add mat-flat-button (#11587)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
…________________________________
What to do if you already signed the CLA
Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version<https://opensource.google.com/docs/cla/#troubleshoot>).
* The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
* The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#11587 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVoy3bR1KEKFFcvZGrAyVVh7jRjaKIkQks5t3xpzgaJpZM4UUGN4>.
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a couple of nitpicks.
src/lib/button/button.md
Outdated
@@ -8,23 +8,22 @@ and accessible experience for users. A `<button>` element should be used wheneve | |||
is performed. An `<a>` element should be used whenever the user will _navigate_ to another view. | |||
|
|||
|
|||
There are five button variants, each applied as an attribute: | |||
There are seven button variants, each applied as an attribute: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to "several button variants"? Otherwise we'll keep forgetting to update the number when we decide to add more.
src/lib/button/button.md
Outdated
| `mat-raised-button` | Rectangular button w/ elevation | | ||
| `mat-stroked-button` | Rectangular button w/ an outline border | | ||
| `mat-button` | Rectangular text button w/ no elevation. | | ||
| `mat-raised-button` | Rectangular contained button w/ elevation | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it, the punctuation on these isn't consistent. Some descriptions end with a full-stop and some don't. Can you add full stops to all of them?
Nitpicks fixed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
and remove incorrect theming paragraph. By default, all buttons use the primary color.