Skip to content

docs(button): add mat-flat-button #11587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2018
Merged

Conversation

sir-boformer
Copy link
Contributor

and remove incorrect theming paragraph. By default, all buttons use the primary color.

and remove incorrect theming paragraph. By default, all buttons use the primary color.
@sir-boformer sir-boformer requested a review from tinayuangao as a code owner May 30, 2018 22:16
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 30, 2018
@sir-boformer
Copy link
Contributor Author

sir-boformer commented May 30, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 30, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple of nitpicks.

@@ -8,23 +8,22 @@ and accessible experience for users. A `<button>` element should be used wheneve
is performed. An `<a>` element should be used whenever the user will _navigate_ to another view.


There are five button variants, each applied as an attribute:
There are seven button variants, each applied as an attribute:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to "several button variants"? Otherwise we'll keep forgetting to update the number when we decide to add more.

| `mat-raised-button` | Rectangular button w/ elevation |
| `mat-stroked-button` | Rectangular button w/ an outline border |
| `mat-button` | Rectangular text button w/ no elevation. |
| `mat-raised-button` | Rectangular contained button w/ elevation |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, the punctuation on these isn't consistent. Some descriptions end with a full-stop and some don't. Can you add full stops to all of them?

@sir-boformer
Copy link
Contributor Author

Nitpicks fixed.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 31, 2018
@josephperrott josephperrott merged commit 2082af7 into angular:master May 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants