docs(chips): make separatorKeysCodes readonly #11830
Conversation
Make separatorKeysCodes readonly because it isn't changed after component is intialized.
googlebot
added
the
cla: yes
| @@ -17,7 +17,7 @@ export class ChipsInputExample { | |||
| addOnBlur: boolean = true; | |||
|
|
|||
| // Enter, comma | |||
| separatorKeysCodes = [ENTER, COMMA]; | |||
| readonly separatorKeysCodes = [ENTER, COMMA]; | |||
There was a problem hiding this comment.
Is there a strong reason to do this in the example?
There was a problem hiding this comment.
In the example, it looks like the key codes are essentially constants, so I think it would make sense if we add the readonly modifier. The motivation for this change proposal came from a teammate who copy pasted the code from the example and interpreted the example code as best practices (i.e. omitting the readonly).
jelbourn
added
pr: lgtm
docs
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
@jhuang314 Could you please rebase? Thanks! |
|
Hi @jhuang314! This PR has merge conflicts due to recent upstream merges. |
josephperrott
removed
the
action: merge
josephperrott
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Make separatorKeysCodes readonly because it isn't changed after component is intialized.