feat: support lazy-loading HammerJS w/ Angular 6.1 #11960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
G
googlebot
added
the
cla: yes
crisbeto
approved these changes
Jun 28, 2018
| // If HammerJS is not loaded here, return the noop HammerInstance. This is necessary to | ||
| // ensure that omitting HammerJS completely will not cause any errors while *also* supporting | ||
| // the lazy-loading of HammerJS via the HAMMER_LOADER token introduced in Angular 6.1. | ||
| // Because we can't depend on HAMMER_LOADER's existance until 7.0, we have to always set |
There was a problem hiding this comment.
Can you add an @deletion-target for 7.0 here so we remember to update it once 7.0 is out?
crisbeto
added
pr: lgtm
action: merge
josephperrott
added
the
blocked
|
Blocked by angular/angular#24682 |
josephperrott
removed
the
action: merge
alfaproject
reviewed
Jun 28, 2018
| @@ -44,12 +44,35 @@ describe('GestureConfig', () => { | |||
| expect(firstCallArgs[1].cssProps.touchAction).toBe('auto'); | |||
| }); | |||
|
|
|||
| it('should should not error when HammerJS is not loaded', () => { | |||
jelbourn
removed
the
blocked
|
@josephperrott unblocked now that the requisite Angular change is synced |
josephperrott
approved these changes
Jul 9, 2018
josephperrott
added
action: merge
jelbourn
added
action: merge
Angular 6.1 adds the HAMMER_LOADER token that can be used to lazy-load HammerJS. This commit updates Angular Material's gesture config to be compatible with lazy-loading HammerJS by: * Only reading `window.Hammer` after Angular knows that HammerJS has been loaded. * Always registering the set of gesture events used in the Angular Material components (instead of registering no events when Hammer is absent). Once we are able to depend on HAMMER_LOADER itself (in v7.0), this can be simplified a bit.
|
Jar jar binks lives on! |
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
Angular 6.1 adds the HAMMER_LOADER token that can be used to lazy-load HammerJS. This commit updates Angular Material's gesture config to be compatible with lazy-loading HammerJS by: * Only reading `window.Hammer` after Angular knows that HammerJS has been loaded. * Always registering the set of gesture events used in the Angular Material components (instead of registering no events when Hammer is absent). Once we are able to depend on HAMMER_LOADER itself (in v7.0), this can be simplified a bit.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 6.1 adds the HAMMER_LOADER token that can be used to lazy-load
HammerJS. This commit updates Angular Material's gesture config to be
compatible with lazy-loading HammerJS by:
window.Hammerafter Angular knows that HammerJS hasbeen loaded.
Material components (instead of registering no events when Hammer is
absent).
Once we are able to depend on HAMMER_LOADER itself (in v7.0), this can
be simplified a bit.