Skip to content

Docs: Adds new button examples #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

FrederikSchlemmer
Copy link
Contributor

Examples for the new buttons (stroked & flat) where missing in the documentation.

Fixes #11974

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 29, 2018
@FrederikSchlemmer
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 29, 2018
@@ -72,3 +62,28 @@ <h3>Mini Fab Buttons</h3>
</button>
<a mat-mini-fab routerLink=".">Link</a>
</div>

<h3>Stroked Buttons</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the stroked and flat buttons should be above the icon and fab buttons.

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Jun 29, 2018
@FrederikSchlemmer
Copy link
Contributor Author

@josephperrott Thanks for the review! Finished your requested changes.

@@ -72,3 +82,7 @@ <h3>Mini Fab Buttons</h3>
</button>
<a mat-mini-fab routerLink=".">Link</a>
</div>

<!-- Copyright 2018 Google Inc. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copyright doesn't have to go here; it's added automatically from the docs site

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks for the review! Copyright is removed!

Typo correction


Cleanup basic buttons


docs: Moves the flat/strocked buttons above icon/fab/mini-fab buttons

Requested changes
docs: deletes automatically created copyright
@josephperrott josephperrott added pr: merge safe action: merge The PR is ready for merge by the caretaker labels Jul 12, 2018
@josephperrott josephperrott merged commit 4ffb39f into angular:master Jul 17, 2018
josephperrott pushed a commit that referenced this pull request Jul 17, 2018
josephperrott pushed a commit that referenced this pull request Jul 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add examples of flat and stroked button to documentation
4 participants