Skip to content

doc(card): fix landmark roles link #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2018
Merged

doc(card): fix landmark roles link #12018

merged 2 commits into from
Jul 5, 2018

Conversation

heavybeard
Copy link
Contributor

No description provided.

@heavybeard heavybeard requested a review from jelbourn as a code owner July 2, 2018 14:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 2, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 2, 2018
@ngbot
Copy link

ngbot bot commented Jul 2, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@heavybeard
Copy link
Contributor Author

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Jul 2, 2018
@josephperrott
Copy link
Member

I am not sure where they should go with w3 updating the site. @jelbourn @mmalerba @crisbeto thoughts?

@mmalerba
Copy link
Contributor

mmalerba commented Jul 3, 2018

@heavybeard
Copy link
Contributor Author

@josephperrott , I have updated the links with the new ones posted by @mmalerba (they seem perfect for documentation)

@mmalerba mmalerba merged commit 2ac5baa into angular:master Jul 5, 2018
mmalerba pushed a commit that referenced this pull request Jul 9, 2018
* doc(card): fix landmark roles link

* doc(card): fix roles links with updated w3 routes
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
* doc(card): fix landmark roles link

* doc(card): fix roles links with updated w3 routes
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants