fix(sidenav): continuously hitting zone when using autosize option #12067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the sidenav going into an infinite change detection loop when using the `autosize` option. Initially this was fixed in angular#11231, but it got reintroduced in angular#11986 where we started comparing `0` against `null` which always evaluates to true. Fixes angular#11215.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Jul 6, 2018
mmalerba
added
P1
|
@crisbeto any way to add a test for this since we've already had a regression once? |
|
I think it would be difficult to add a test for this. We'd have to add something that counts the number of change detection runs which would be very flaky. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sidenav going into an infinite change detection loop when using the
autosizeoption. Initially this was fixed in #11231, but it got reintroduced in #11986 where we started comparing0againstnullwhich always evaluates to true.Fixes #11215.