fix(radio): circle not being greyed out when disabled #12127
Conversation
googlebot
added
the
cla: yes
src/lib/radio/_radio-theme.scss
Outdated
| @@ -53,6 +39,22 @@ | |||
| &.mat-warn { | |||
| @include _mat-radio-color($warn); | |||
| } | |||
|
|
|||
| &.mat-radio-disabled { | |||
| &.mat-radio-checked .mat-radio-outer-circle, | |||
There was a problem hiding this comment.
Is that just too make sure that the specificity is high enough? Since you already moved the code below it should be already enough?
There was a problem hiding this comment.
It's not enough since the selector above is a combination of classes .mat-radio-button.mat-accent which makes it higher. Ideally we wouldn't have this combination, but it would be a breaking change at this point.
There was a problem hiding this comment.
I see, can we add a short comment for it?
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles. Fixes angular#12125.
crisbeto
force-pushed
the
12125/radio-disabled
branch
from
de0700f to
3b1280a
Compare
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles. Fixes #12125.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the radio button circle not being greyed out when it is disabled. It seems like we had the styles in place already, however they were with a lower specificity than the other theme styles.
Fixes #12125.