Skip to content

fix(slide-toggle): no color demarcation in high contrast black mode #12150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Fixes that there is no way to identify a checked slide-toggle in high contrast mode.
  • Fixes that the slide-toggle bar is not visible in high-contrast mode white.
  • Moves high contrast CSS to the end of the SCSS file in order to separate normal styles that are required for the slide-toggle from the high contrast custom CSS.

e.g. White on Black

Image from Gyazo

* Fixes that there is no way to identify a checked slide-toggle in high contrast mode.
* Fixes that the slide-toggle bar is not visible in high-contrast mode white.
* Moves high contrast CSS to the end of the SCSS file in order to separate normal styles that are required for the slide-toggle from the high contrast custom CSS.
@devversion devversion added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jul 11, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 11, 2018
@jelbourn jelbourn merged commit b5fd6de into angular:master Jul 12, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
…12150)

* Fixes that there is no way to identify a checked slide-toggle in high contrast mode.
* Fixes that the slide-toggle bar is not visible in high-contrast mode white.
* Moves high contrast CSS to the end of the SCSS file in order to separate normal styles that are required for the slide-toggle from the high contrast custom CSS.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants