Skip to content

chore(examples): fix tab group example title #12255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Fixes the title for the tab-group-dynamic example.

* Fixes the title for the `tab-group-dynamic` example.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 18, 2018
@devversion devversion added target: patch This PR is targeted for the next patch release and removed target: master only labels Jul 18, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,7 @@ import {Component} from '@angular/core';
import {FormControl} from '@angular/forms';

/**
* @title Tag group with dynamically changing tabs
* @title Tab group with dynamically changing tabs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still technically a group of tags ¯\_(ツ)_/¯.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 18, 2018
@josephperrott josephperrott merged commit 783a5c9 into angular:master Jul 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants