Skip to content

fix(card): incorrectly inverting inset divider in rtl #12285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2018

Conversation

crisbeto
Copy link
Member

Fixes the inset divider on a card in RTL being pushed outside the card.

For reference:
angular_material_-_google_chrome_2018-07-19_22-06-27

Fixes the inset divider on a card in RTL being pushed outside the card.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 19, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner July 19, 2018 20:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 19, 2018
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 19, 2018
@ngbot
Copy link

ngbot bot commented Jul 19, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required status "ci/circleci: build"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit fba4a93 into angular:master Jul 29, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
Fixes the inset divider on a card in RTL being pushed outside the card.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants