Skip to content

chore: bump to latest tslint version #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

crisbeto
Copy link
Member

Bumps to the latest version of tslint so we don't fall behind too much.

Bumps to the latest version of `tslint` so we don't fall behind too much.
@crisbeto crisbeto requested a review from jelbourn as a code owner July 20, 2018 20:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn't look like we felt too much behind though.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 20, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member Author

We didn't, but I want to stay on the current one since we have a handful of custom rules.

@devversion
Copy link
Member

Yeah, no worries. It's good to keep those up-to-date. Just replied because the commit description kind of sounded like we were multiple major versions behind.

@josephperrott josephperrott merged commit 3b50e44 into angular:master Jul 21, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants