fix(aria-describer): messages not being read out in IE and Edge #12304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
reviewed
Jul 24, 2018
| // We only disable `aria-hidden` for these platforms, because it comes with the | ||
| // disadvantage that people might hit the messages when they've navigated past | ||
| // the end of the document using the arrow keys. | ||
| messagesContainer.setAttribute('aria-hidden', canBeAriaHidden + ''); |
There was a problem hiding this comment.
Normally I think we do canBeAriaHidden.toString()? Wouldn't that work as well? seems a bit more consistent with the approach we also use for setting the aria-disabled state on other components.
There was a problem hiding this comment.
I prefer `${canBeAriaHidden}` but don't really care that much
devversion
approved these changes
Jul 24, 2018
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
2 times, most recently
from
d4fe09a to
f4b4bf5
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
f4b4bf5 to
9964648
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
9964648 to
498db46
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
498db46 to
a187f26
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
a187f26 to
80192c9
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
80192c9 to
9f98064
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
9f98064 to
46bcd47
Compare
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
46bcd47 to
a44322f
Compare
crisbeto
added
P2
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
a44322f to
abdb461
Compare
|
Bumping this to a P2 since this could make some components unusable on IE/Edge with assistive technology. I also spent some time getting the CI to pass again. |
Fixes the messages from the `AriaDescriber` not being read out in Edge or IE, because the message container is `aria-hidden` and has `display: none`. Fixes angular#12298.
crisbeto
force-pushed
the
12298/aria-describer-ie
branch
from
abdb461 to
7ace81c
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fixes the messages from the `AriaDescriber` not being read out in Edge or IE, because the message container is `aria-hidden` and has `display: none`. Fixes #12298.
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
…lar#12304) Fixes the messages from the `AriaDescriber` not being read out in Edge or IE, because the message container is `aria-hidden` and has `display: none`. Fixes angular#12298.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the messages from the
AriaDescribernot being read out in Edge or IE, because the message container isaria-hiddenand hasdisplay: none.Fixes #12298.