Skip to content

fix(schematics): properly detect tsconfig files #12434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 30, 2018

  • Currently the tsconfig files are not being detected properly with the latest Angular CLI version.
  • Improves tslint config comment

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: major This PR is targeted for the next major release pr: lgtm action: merge The PR is ready for merge by the caretaker and removed target: master only labels Jul 30, 2018
@ngbot

This comment has been minimized.

* Currently the `tsconfig` files are not being detected properly with the latest Angular CLI version.
* Improves tslint config comment
@devversion devversion force-pushed the fix/schematics-properly-detect-tsconfig-files branch from 21ab993 to f16973f Compare July 30, 2018 17:38
@jelbourn jelbourn merged commit 08e6653 into angular:master Jul 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants