fix(datepicker): wait for exit animation to finish before detaching content #12440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
reviewed
Jul 30, 2018
mmalerba
added
the
merge: caretaker note
crisbeto
force-pushed
the
datepicker-animation-element-destroy
branch
3 times, most recently
from
399b6b3 to
e11fa08
Compare
crisbeto
force-pushed
the
datepicker-animation-element-destroy
branch
from
e11fa08 to
79f79ce
Compare
crisbeto
force-pushed
the
datepicker-animation-element-destroy
branch
from
79f79ce to
37559cc
Compare
crisbeto
force-pushed
the
datepicker-animation-element-destroy
branch
from
37559cc to
beea098
Compare
…ontent This is something I ran into while working on aligning the datepicker with the most-recent Material design spec. Since angular#9639 we use a portal outlet to render the calendar header. The portal outlet directive will detach in `ngOnDestroy` and it won't wait for the parent animation to finish, which ends up shifting the entire calendar up while it's animating away. The only reason that this isn't visible at the moment is because the current animation isn't configured correctly, which causes it to go to `opacity: 0` immediately.
crisbeto
force-pushed
the
datepicker-animation-element-destroy
branch
from
beea098 to
bace7f9
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
|
I went back to rebase this, but I think that the issue was addressed as a part of the refactor in 7039d3e. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I ran into while working on aligning the datepicker with the most-recent Material design spec. Since #9639 we use a portal outlet to render the calendar header. The portal outlet directive will detach in
ngOnDestroyand it won't wait for the parent animation to finish, which ends up shifting the entire calendar up while it's animating away. The only reason that this isn't visible at the moment is because the current animation isn't configured correctly, which causes it to go toopacity: 0immediately.For reference:
