refactor(schematics): cleanup attribute selector rules #12507
Conversation
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
force-pushed
the
refactor/schematics-cleanup-attribute-selectors
branch
from
0b34535 to
7ba1c5a
Compare
| import * as ts from 'typescript'; | ||
|
|
||
| /** | ||
| * Rule that walks through every string literal that i |
| @@ -0,0 +1,54 @@ | |||
| /** | |||
There was a problem hiding this comment.
Probably in another PR, but we should also make these filenames consistent with the rest of the project (dashes instead of camelCase)
There was a problem hiding this comment.
That does unfortunately not work because TSLint expects the files to the be camel-cased in order to load them.
| /** Method that can be used to replace all search occurrences in a string. */ | ||
| export function findAll(str: string, search: string): number[] { | ||
| /** Finds all occurrences of the given search string in an input string and returns the offsets. */ | ||
| export function findAllSearchOccurrences(input: string, search: string): number[] { |
There was a problem hiding this comment.
I would call this findAllSubstringIndices
devversion
force-pushed
the
refactor/schematics-cleanup-attribute-selectors
branch
from
7ba1c5a to
f484081
Compare
|
@jelbourn Addressed your feedback. Please have another look. |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
josephperrott
added
pr: needs rebase
and removed
action: merge
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
* Cleans up the `attribute-selector` rules by avoiding duplicate code and making the code generally more readable. Also moves all rules tied to the `attributeSelectors` data into a sub directory. * Renames the `findAll` method to `findAllSubstringIndices` because just having `findAll` is very ambiguous. * Removes the unused `extra-stylesheets` file.
devversion
force-pushed
the
refactor/schematics-cleanup-attribute-selectors
branch
from
f484081 to
e82d3a3
Compare
devversion
added
action: merge
|
@josephperrott Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Cleans up the
attribute-selectorrules by avoiding duplicate code, too much indentation and nesting. Also moves all rules tied to theattributeSelectorsdata into a sub directory.Renames the
findAllmethod tofindAllSubstringIndicesbecause just havingfindAllis very ambiguous.Removes the unused
extra-stylesheetsfile.Note: Ignore the changes related to the
findAllSubstringIndicesin the other rules. Those will be cleaned-up and moved into a subdirectory in follow-up PRs. This also makes it easier to differentiate betweenv6andv7data at some point.